Crash with TLS Session Ticket

[masaori335]

I got a crash report testing with ATS 9.1.2 and OpenSSL 3.0.5.

(lldb) bt
* thread #14, name = '[ET_NET 12]', stop reason = EXC_BAD_ACCESS (code=1, address=0x88)
    frame #0: 0x0000000001d4ec19 libcrypto.3.dylib`EVP_MAC_CTX_set_params + 7
  * frame #1: 0x00000000003a296b traffic_server`TLSSessionResumptionSupport::_setSessionInformation(this=0x0000000068168800, keyblock=0x000060000171f1c0, ssl=0x000000000600b600, keyname="\xf6\U00000002c\U00000013xe\xae6\x93YѢ\xb2ga\xa2\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", iv="\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", cipher_ctx=0x0000600003718180, hctx=0x000060000024c540) at TLSSessionResumptionSupport.cc:202:3
    frame #2: 0x00000000003a2722 traffic_server`TLSSessionResumptionSupport::processSessionTicket(this=0x0000000068168800, ssl=0x000000000600b600, keyname="\xf6\U00000002c\U00000013xe\xae6\x93YѢ\xb2ga\xa2\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", iv="\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", cipher_ctx=0x0000600003718180, hctx=0x000060000024c540, enc=1) at TLSSessionResumptionSupport.cc:111:18
    frame #3: 0x000000000038c39b traffic_server`ssl_callback_session_ticket(ssl=0x000000000600b600, keyname="\xf6\U00000002c\U00000013xe\xae6\x93YѢ\xb2ga\xa2\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", iv="\U0000000e\x88e\x9a\x98Ԍ\xcb\xf4\xe9\U0000001f2\xf2*", cipher_ctx=0x0000600003718180, hctx=0x000060000024c540, enc=1) at SSLSessionTicket.cc:54:17
    frame #4: 0x00000000011a30fb libssl.3.dylib`tls_construct_new_session_ticket + 2039
    frame #5: 0x000000000119408f libssl.3.dylib`state_machine + 936
    frame #6: 0x00000000003959a3 traffic_server`SSLAccept(ssl=0x000000000600b600) at SSLUtils.cc:1866:11
    frame #7: 0x000000000036d9ab traffic_server`SSLNetVConnection::sslServerHandShakeEvent(this=0x0000000068168800, err=0x0000000009e0fcf4) at SSLNetVConnection.cc:1255:27
    frame #8: 0x000000000036c2a7 traffic_server`SSLNetVConnection::sslStartHandShake(this=0x0000000068168800, event=0, err=0x0000000009e0fcf4) at SSLNetVConnection.cc:1061:12
    frame #9: 0x0000000000367c5f traffic_server`SSLNetVConnection::net_read_io(this=0x0000000068168800, nh=0x0000000008d7c190, lthread=0x0000000008d78000) at SSLNetVConnection.cc:569:13
    frame #10: 0x00000000003a814d traffic_server`NetHandler::process_ready_list(this=0x0000000008d7c190) at UnixNet.cc:415:11
    frame #11: 0x00000000003a885b traffic_server`NetHandler::waitForActivity(this=0x0000000008d7c190, timeout=60000000) at UnixNet.cc:552:3
    frame #12: 0x00000000003e5e5b traffic_server`EThread::execute_regular(this=0x0000000008d78000) at UnixEThread.cc:303:14
    frame #13: 0x00000000003e62a5 traffic_server`EThread::execute(this=0x0000000008d78000) at UnixEThread.cc:364:11
    frame #14: 0x00000000003e4570 traffic_server`spawn_thread_internal(a=0x0000600002102990) at Thread.cc:91:12

FWIW, it looks like this is fixed on the master and 9.2.x branch.

[masaori335]

#8524 is the fix for this crash.

[masaori335]

We need #8524 if we have another 9.1.x patch version release before the 9.2.0.