Remove legacy IntrusiveDList#10106
Conversation
| arena is destroyed. The destructor can be called if needed but in general if a destructor is needed | ||
| it is probably not a class that should be constructed in the arena. Looking at | ||
| :class:`IntrusiveDList` again for an example, if this is used to link objects in the arena, there is | ||
| :code`:`swoc::IntrusiveDList` again for an example, if this is used to link objects in the arena, there is |
There was a problem hiding this comment.
For some reason, Sphinx only likes this the first time it's used: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/2470/Sphinx_20Docs/developer-guide/internal-libraries/MemArena.en.html#memarena
There was a problem hiding this comment.
The underlying problem is the class data is populated by other document files, in this particular case by "intrusive_dlist.en.rst" which no longer exists.
There was a problem hiding this comment.
The change doesn' t look any better to me: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/2472/Sphinx_20Docs/developer-guide/internal-libraries/MemArena.en.html#memarena . But anyway.
There was a problem hiding this comment.
The curse of Sphinx is inescapable.
SolidWallOfCode
force-pushed
the
swoc-intrusive-dlist
branch
from
c1bc657 to
ab9df51
Compare
Revert "libswoc: Update IntrusiveHashMap in HTTP session manager. (apache#9872)" apache#9872 This reverts commit ca4f8cd. I'm reverting this IntrusiveHashMap switch to libswoc because it introduces a spike in our origin side connections. The following is also reverted to add back the IntrusiveHashMap and IntrusiveDList implementations: Revert "libswoc: Remove legacy IntrusiveHashMap (apache#10104)" This reverts commit 5706e3b. Revert "libswoc: Remove legacy IntrusiveDList. (apache#10106)" This reverts commit 5d0a549. Co-authored-by: bneradt <bneradt@yahooinc.com>
2 participants
No description provided.