Skip to content

Preserve unmapped url regardless of need for remapping#10304

Merged
maskit merged 1 commit intoapache:masterfrom
maskit:preserve_unmapped
Sep 11, 2023
Merged

Preserve unmapped url regardless of need for remapping#10304
maskit merged 1 commit intoapache:masterfrom
maskit:preserve_unmapped

Conversation

@maskit
Copy link
Copy Markdown
Member

@maskit maskit commented Aug 29, 2023

#10146 discovered that marking a parent host down causes a crash if a request is set to skip remapping. Not only OCSP requests but also any requests that skip remapping can cause the crash.

(lldb) bt
* thread #3, name = '[ET_NET 0]', stop reason = signal SIGABRT
  * frame #0: 0x000000018c190764 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x000000018c1c7c28 libsystem_pthread.dylib`pthread_kill + 288
    frame #2: 0x000000018c0d5ae8 libsystem_c.dylib`abort + 180
    frame #3: 0x0000000101060878 traffic_server`ink_abort(message_format="%s:%d: failed assertion `%s`") at ink_error.cc:99:3
    frame #4: 0x00000001010555bc traffic_server`_ink_assert(expression="valid()", file="/Users/mkitajo/src/github.com/trafficserver/proxy/hdrs/URL.h", line=595) at ink_assert.cc:37:3
    frame #5: 0x00000001000b17c0 traffic_server`URL::host_get(this=0x0000000113017718, length=0x000000010af12760) at URL.h:595:3
    frame #6: 0x000000010038cbcc traffic_server`HttpSM::mark_host_failure(this=0x0000000113016ae0, info=0x0000000113016cb8, time_down=ts_time @ 0x000000010af126a0) at HttpSM.cc:5750:62
    frame #7: 0x000000010038b824 traffic_server`HttpSM::do_hostdb_update_if_necessary(this=0x0000000113016ae0) at HttpSM.cc:4532:11
    frame #8: 0x00000001004771e4 traffic_server`HttpTransact::handle_server_connection_not_open(s=0x0000000113016be8) at HttpTransact.cc:3899:21
    frame #9: 0x000000010048ca78 traffic_server`HttpTransact::handle_response_from_server(s=0x0000000113016be8) at HttpTransact.cc:3799:7
    frame #10: 0x0000000100452034 traffic_server`HttpTransact::HandleResponse(s=0x0000000113016be8) at HttpTransact.cc:3450:5

The backtrace above shows ink_abort but a real crash happens on production (non-debug build).

@maskit maskit added this to the 10.0.0 milestone Aug 29, 2023
@maskit maskit self-assigned this Aug 29, 2023
@maskit
Copy link
Copy Markdown
Member Author

maskit commented Sep 6, 2023

[approve ci autest]

@maskit maskit mentioned this pull request Sep 7, 2023
Merged
@maskit
Copy link
Copy Markdown
Member Author

maskit commented Sep 7, 2023

This depends on #10386.

@maskit
Copy link
Copy Markdown
Member Author

maskit commented Sep 11, 2023

[approve ci]

@maskit
Copy link
Copy Markdown
Member Author

maskit commented Sep 11, 2023

[approve ci autest]

@maskit maskit merged commit 1952751 into apache:master Sep 11, 2023
zwoop pushed a commit that referenced this pull request Sep 13, 2023
@maskit @zwoop
Preserve unmapped url regardless of need for remapping (#10304)
cd76df8 
(cherry picked from commit 1952751)
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Sep 13, 2023

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.3 Sep 13, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@maskit @zwoop
Preserve unmapped url regardless of need for remapping (apache#10304)
97ef80c
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge commit '236b749b2b3cc746829ad534a7034ab7799d1b71'
8cb4c62 
* commit '236b749b2b3cc746829ad534a7034ab7799d1b71':
  Allow origins to do TLS renegotiation (apache#10385)
  Remove deprecated debug output functions from 21 source files. (apache#9683)
  Fixes some make test build problems (apache#10402)
  Removes unused Errata functions from WCCP (apache#10380)
  Move InkAPI.cc into src/api (apache#10315)
  cmake: Generate files in rc, install the trafficserver script (apache#10367)
  Add support for OCSP requests by GET method (apache#10306)
  Preserve unmapped url regardless of need for remapping (apache#10304)
  Add TSVConnFdGet api (apache#10324)
  include/ts: comma on all last enum elements (apache#10400)
  cmake: Add remaining plugins without external deps (apache#10395)
  CID-1508974 (apache#10397)
  CID-1508987 (apache#10398)
  Coverity 1518564: fix off by one (apache#10401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SolidWallOfCode SolidWallOfCode SolidWallOfCode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maskit maskit

Labels

Core Crash

Projects

None yet

Milestone

9.2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@maskit @zwoop @SolidWallOfCode