Export Regex support to plugins.#10722
Merged
SolidWallOfCode merged 4 commits intoapache:masterfrom Nov 13, 2023
Merged
Conversation
SolidWallOfCode
force-pushed
the
export-regex
branch
from
6354d13 to
99a400e
Compare
Contributor
|
Shouldn't test_Regex.cc also move, to src/tscpp/util/unit_tests ? |
SolidWallOfCode
force-pushed
the
export-regex
branch
7 times, most recently
from
6372256 to
b8211d8
Compare
Contributor
|
Do we need a proposal on the dev mailing list for tscpp/util additions, since it's visible to plugins? Maybe you already did it, and I forgot. I'm inclined to approve this once it passes CI. But it seems to be somewhat controversial (general purpose wrappers/utilities in general), so we wouldn't want anyone to feel it was snuck in. |
SolidWallOfCode
force-pushed
the
export-regex
branch
from
b8211d8 to
184e262
Compare
Contributor
|
[approve ci clang-format] |
bryancall
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically move to "tscpp/util" and then update the includes.
Remove core dependencies from regex.