ConnectionTracker: Remove queue implementation#10825
Merged
bneradt merged 1 commit intoapache:masterfrom Nov 18, 2023
Merged
Conversation
Connection count queueing functionality was removed via apache#7302. This removes some dead code that was still associated with that now-removed feature.
bneradt
commented
Nov 18, 2023
Comment on lines
-5887
to
-5889
| // The request is now not queued. This is important because server retries reuse the t_state. | ||
| t_state.outbound_conn_track_state.dequeue(); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This might seem like a concerning removal of a use of dequeue, but note that enqueue was never called. Thus this call was always a no-op.
SolidWallOfCode
approved these changes
Nov 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection count queueing functionality was removed via #7302. This removes some dead code that was still associated with that now-removed feature.