Skip to content

Implement RAII for PreservationTable#11825

Merged
JosiahWI merged 5 commits into
apache:masterfrom
JosiahWI:refactor/preservation-table-condtor
Nov 7, 2024
Merged

Implement RAII for PreservationTable#11825
JosiahWI merged 5 commits into
apache:masterfrom
JosiahWI:refactor/preservation-table-condtor

Conversation

@JosiahWI
Copy link
Copy Markdown
Contributor

This is pretty straightforward, but the catch is what to do if there are unreleased evacuation blocks at destruction. I still need to write code to handle printing a warning or something to that effect before this is fully ready.

@JosiahWI JosiahWI added this to the 10.1.0 milestone Oct 21, 2024
@JosiahWI JosiahWI self-assigned this Oct 21, 2024
Comment thread src/iocore/cache/StripeSM.cc
@JosiahWI
Copy link
Copy Markdown
Contributor Author

The AuTest bad chunked encoding failed.

     file /tmp/sandbox/bad_chunked_encoding/_output/bad_chunked_encoding-verifier-server2/stream.stdout.txt : Verify that the body never got through. - Failed
        Reason: Contents of /tmp/sandbox/bad_chunked_encoding/_output/bad_chunked_encoding-verifier-server2/stream.stdout.txt contains expression: "abc"
           Details:
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 17
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 35
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 53
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 71
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 95
             Via: http/1.1 traffic_server[ed350727-0c1d-4e42-9a5d-aeca5abc9853] (ApacheTrafficServer/10.1.0) : 119

@JosiahWI
Copy link
Copy Markdown
Contributor Author

Not rerunning CI since this is a draft and I already got enough confidence that AuTest found no problems with it.

@bryancall bryancall requested a review from moonchen October 28, 2024 22:06
@JosiahWI JosiahWI marked this pull request as ready for review October 29, 2024 17:11
@JosiahWI
Copy link
Copy Markdown
Contributor Author

JosiahWI commented Nov 4, 2024

The last test run of the AuTest remap_acl failed.

Copy link
Copy Markdown
Contributor

@moonchen moonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@JosiahWI JosiahWI merged commit 3ea4d8f into apache:master Nov 7, 2024
@JosiahWI JosiahWI deleted the refactor/preservation-table-condtor branch December 5, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants