Implement RAII for PreservationTable#11825
Merged
JosiahWI merged 5 commits intoNov 7, 2024
Merged
Conversation
JosiahWI
commented
Oct 21, 2024
Contributor
Author
|
The AuTest bad chunked encoding failed. |
Contributor
Author
|
Not rerunning CI since this is a draft and I already got enough confidence that AuTest found no problems with it. |
Contributor
Author
|
The last test run of the AuTest remap_acl failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty straightforward, but the catch is what to do if there are unreleased evacuation blocks at destruction. I still need to write code to handle printing a warning or something to that effect before this is fully ready.