Fix cache initialization#12127
Conversation
|
The Debian CI failed (bneradt reran it, thanks!) with a free() error during one of the cache_Alternate_S_to_L tests. Probably a real issue, but probably not easy to diagnose. |
| fd{disk->fd}, | ||
| disk{disk}, | ||
| _preserved_dirs{static_cast<int>(len)} | ||
| _preserved_dirs{len} |
There was a problem hiding this comment.
Using off_t seems makes sense because this Stripe::len is off_t.
trafficserver/src/iocore/cache/Stripe.h
Line 76 in 41523d1
There was a problem hiding this comment.
I could also look at how big a change it would be to make the table size an off_t type, but I need to be careful because I don't understand yet why they were different in the first place. It seems like using the same type for both would be more consistent.
There was a problem hiding this comment.
This has not been done yet, but I am adding it to my personal TODO.
|
Cherry-picked to 10.1.x branch |
(cherry picked from commit 090141a)
4 participants
Fixes #12124
@bneradt tested this patch and confirmed it resolves the issue.