Reset HttpCacheSM on following redirect#12182
Merged
masaori335 merged 1 commit intoapache:masterfrom Apr 14, 2025
Merged
Conversation
Contributor
|
Would also be interesting to know whether this affects #11700. |
JosiahWI
approved these changes
Apr 14, 2025
Contributor
JosiahWI
left a comment
There was a problem hiding this comment.
Very nice fix. I believe I found this bug during testing earlier, but I did not have time to confirm it or track down what caused it.
I agree we need to look at how captive_action and pending_action are handled... I think other bugs are probably also related to it.
Contributor
Author
|
For the record, the issue happens only on 10.0.x and master. Because we reverted commits from 9.2.x branch. |
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 15, 2025
(cherry picked from commit 7eb355f)
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We face an issue that
http.current_active_client_connectionsmetrics keep increasing. After investigation with @cmcfarlen and @moonchen, we foundHttpSMhangs onstate_cache_open_readwhen it follows redirect andHttpCacheSM::captive_actionwas cancelled. BecauseHttpCacheSM::state_cache_open_readdoes nothing.trafficserver/src/proxy/http/HttpCacheSM.cc
Lines 106 to 112 in b1e9327
To fix the issue, this PR does reset
captive_action.cancelledand other counters ofHttpCacheSMon following redirect.From our testing, this patch seems working, however,
captive_actionandpending_actionrelated code seems pretty odd. They should be fixed.