Reset write lock state to init after closing write (#12215)#12559
Merged
ezelkow1 merged 1 commit intoapache:9.2.xfrom Oct 14, 2025
Merged
Reset write lock state to init after closing write (#12215)#12559ezelkow1 merged 1 commit intoapache:9.2.xfrom
ezelkow1 merged 1 commit intoapache:9.2.xfrom
Conversation
This commit mitigates the crash reported in apache#11700. That crash happens when a redirect is issued on a state machine that has already cached a response and closed the cache write VC. After this patch, the state machine will likely open a new cache VC to cache the response from the origin it was redirected to. We will refer to the original origin as A, and the origin the state machine was redirected to after the response from A as B. We have not yet reproduced this locally - the exact sequence of events that gets the state machine into this state are still unknown. (cherry picked from commit 5c0aaf2)
JosiahWI
approved these changes
Oct 14, 2025
github-project-automation
Bot
moved this from For Review
to Ready to Merge
in 9.2.x Branch and Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit mitigates the crash reported in #11700. That crash happens when a redirect is issued on a state machine that has already cached a response and closed the cache write VC.
After this patch, the state machine will likely open a new cache VC to cache the response from the origin it was redirected to. We will refer to the original origin as A, and the origin the state machine was redirected to after the response from A as B.
We have not yet reproduced this locally - the exact sequence of events that gets the state machine into this state are still unknown.
(cherry picked from commit 5c0aaf2)