Fix autest.sh.in to preserve autest exit code#12732
Merged
bryancall merged 1 commit intoapache:masterfrom Dec 4, 2025
Merged
Conversation
The trailing if-blocks for restoring UDS test directories were overwriting autest's exit code with 0, causing test failures to be silently ignored in CI. Now we capture the exit code immediately after autest runs and exit with it at the end of the script.
bneradt
approved these changes
Dec 4, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Thanks. We need to preserve the correct exit code for CI to recognize when any of the autests failed.
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Dec 11, 2025
The trailing if-blocks for restoring UDS test directories were overwriting autest's exit code with 0, causing test failures to be silently ignored in CI. Now we capture the exit code immediately after autest runs and exit with it at the end of the script. (cherry picked from commit 671f6ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trailing if-blocks for restoring UDS test directories were overwriting autest's exit code with 0, causing test failures to be silently ignored in CI.
Now we capture the exit code immediately after autest runs and exit with it at the end of the script.
This was discovered while investigating why PR #12727 was passing CI despite having a failing test.