Skip to content

Fix: Handle EBADF in synserver accept instead of aborting #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 2 commits into from
Mar 2, 2026
+12 −2
Merged

Fix: Handle EBADF in synserver accept instead of aborting #12930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa4b0f2
Handle EBADF in synserver accept instead of aborting
bryancall Feb 27, 2026
b17b195
Address review feedback: Dbg instead of Warning, restore comment
bryancall Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/api/InkAPITest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,8 +893,13 @@ static int
synserver_vc_refuse(TSCont contp, TSEvent event, void *data)
{
if (event != TS_EVENT_NET_ACCEPT && event != TS_EVENT_NET_ACCEPT_FAILED) {
// net_accept() passes negated errno as data on EVENT_ERROR; Linux MAX_ERRNO is 4095
intptr_t data_val = reinterpret_cast<intptr_t>(data);
// Listening socket closed by synserver_stop while accept was pending.
if (event == TS_EVENT_ERROR && data_val == -EBADF) {
Dbg(dbg_ctl_SockServer, "synserver_vc_refuse: accept got EBADF, listener likely shut down");
return TS_EVENT_IMMEDIATE;
}
// net_accept() passes negated errno as data on EVENT_ERROR; Linux MAX_ERRNO is 4095
if (data_val < 0 && data_val >= -4095) {
int err = static_cast<int>(-data_val);
Comment thread
bryancall marked this conversation as resolved.
ink_abort("synserver_vc_refuse: unexpected event %d, accept errno: %s (%d)", event, strerror(err), err);
Expand Down Expand Up @@ -923,8 +928,13 @@ static int
synserver_vc_accept(TSCont contp, TSEvent event, void *data)
{
if (event != TS_EVENT_NET_ACCEPT && event != TS_EVENT_NET_ACCEPT_FAILED) {
// net_accept() passes negated errno as data on EVENT_ERROR; Linux MAX_ERRNO is 4095
intptr_t data_val = reinterpret_cast<intptr_t>(data);
// Listening socket closed by synserver_stop while accept was pending.
if (event == TS_EVENT_ERROR && data_val == -EBADF) {
Dbg(dbg_ctl_SockServer, "synserver_vc_accept: accept got EBADF, listener likely shut down");
return TS_EVENT_IMMEDIATE;
}
// net_accept() passes negated errno as data on EVENT_ERROR; Linux MAX_ERRNO is 4095
if (data_val < 0 && data_val >= -4095) {
int err = static_cast<int>(-data_val);
Comment thread
bryancall marked this conversation as resolved.
ink_abort("synserver_vc_accept: unexpected event %d, accept errno: %s (%d)", event, strerror(err), err);
Expand Down