Skip to content

Ts 3647#214

Closed
persiaAziz-zz wants to merge 25 commits intoapache:masterfrom
persiaAziz-zz:TS-3647
Closed

Ts 3647#214
persiaAziz-zz wants to merge 25 commits intoapache:masterfrom
persiaAziz-zz:TS-3647

Conversation

@persiaAziz-zz
Copy link
Copy Markdown
Contributor

  1. CPP API of
    TSHttpTxnConfigIntSet
    TSHttpTxnConfigIntGet
    TSHttpTxnConfigFloatSet
    TSHttpTxnConfigFloatGet
    TSHttpTxnConfigStringSet
    TSHttpTxnConfigStringGet
    TSHttpTxnConfigFind
  2. Wrapper function for TSPluginRegister , called TSRegisterPlugin
  3. TSRegisterPlugin() included in all the PluginInit implementations of the example CPPAPI Plugins

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this. The pattern we've always followed with the ats c++ api is that it shouldn't require including any C header files. We've typically just duplicated enums so TSOverridableConfigKey should be an enum in Transaction.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Let me think about that a bit. I have an idea on how to deal with this but I need to flesh it out.

SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request May 7, 2016
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request May 10, 2021
traffic_dump: Make client-request gathered in a global hook (apache#6500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants