Remove the correct entry from priority queue and insert the new node into the queue#2359
Merged
zwoop merged 1 commit intoapache:masterfrom Aug 11, 2017
scw00:H2ISSUE
Merged
Remove the correct entry from priority queue and insert the new node into the queue#2359zwoop merged 1 commit intoapache:masterfrom scw00:H2ISSUE
zwoop merged 1 commit intoapache:masterfrom
scw00:H2ISSUE
Conversation
scw00
changed the title
masaori335
reviewed
Aug 11, 2017
| parent->children.push(node); | ||
| if (!node->queue->empty()) { | ||
| parent->queue->push(node->entry); | ||
| parent->queued = true; |
Contributor
There was a problem hiding this comment.
Should be node->queued = true? Because queued flag indicates the node is in the queue or not, if I remember correctly.
Member
Author
|
Hi @masaori335 , updated please review again!! |
Contributor
|
Testing this on docs again, will check in the morning if it behaves. Please make sure to add a Project of 7.x for the PRs that are 7.x candidates :-) |
Contributor
|
This looks good now on Docs, I'm gonna merge this and cherry-pick to 7.1.x. Thanks! |
zwoop
approved these changes
Aug 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr try to fix #2323