fix the missing lock in TSVConnFdCreate api#2643
Merged
scw00 merged 1 commit intoapache:masterfrom Oct 16, 2017
Merged
Conversation
Member
Author
|
Since we don't use this api, it is 8.0.0 only ! |
scw00
force-pushed
the
fix_api
branch
3 times, most recently
from
68d9e29 to
0eeb81b
Compare
Member
Author
|
updated Document ! |
scw00
force-pushed
the
fix_api
branch
8 times, most recently
from
e347cd1 to
b7e5fa2
Compare
oknet
requested changes
Oct 10, 2017
| res = -errno; | ||
| goto fail; | ||
| } | ||
| goto fail; |
Member
There was a problem hiding this comment.
This should be clean up since the con.fd is not closed. The net_connections_currently_open_stat can be decreased by free(t).
Member
Author
There was a problem hiding this comment.
Based on discussion, I need to open a new pr for this net_connections_currently_open_stat.
scw00
force-pushed
the
fix_api
branch
3 times, most recently
from
66e3c8b to
fae3db3
Compare
oknet
approved these changes
Oct 12, 2017
| return true; | ||
| if (fd > hyper_emergency) { | ||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
inform the caller to close the fd as we don't care the type of throttle.
Member
Author
|
ping @jpeach ! |
Contributor
|
Is this a candidate for 7.1.x ? |
Contributor
|
@scw00 Oops, forgot to ping you. Should we backport this to 7.1.x ? |
Member
Author
|
I think 8.0.0 may be better since we don't use this api. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.