Skip to content

Treat SSL_ERROR_SSL as EPIPE within SSLNetVC::load_buffer_and_write()#2748

Merged
zwoop merged 1 commit intoapache:masterfrom
oknet:i2748
Nov 1, 2017
Merged

Treat SSL_ERROR_SSL as EPIPE within SSLNetVC::load_buffer_and_write()#2748
zwoop merged 1 commit intoapache:masterfrom
oknet:i2748

Conversation

@oknet
Copy link
Copy Markdown
Member

@oknet oknet commented Nov 1, 2017

Compare to the SSLNetVC::ssl_read_from_net, it return SSL_READ_ERROR if sslErr is SSL_ERROR_SSL, but the SSLNetVC::load_buffer_and_write does not change the result (num_really_written).

This closes #2705.

Compare to the SSLNetVC::ssl_read_from_net, it return `SSL_READ_ERROR`
if sslErr is `SSL_ERROR_SSL`, but the SSLNetVC::load_buffer_and_write
does not change the result (num_really_written).

This closes apache#2705
@oknet oknet requested review from shinrich and zwoop November 1, 2017 07:38
@oknet oknet added the TLS label Nov 1, 2017
@oknet
Copy link
Copy Markdown
Member Author

oknet commented Nov 1, 2017

Link to TS-4522, PR #701 and commit 40f07b5

@bryancall bryancall added this to the 8.0.0 milestone Nov 1, 2017
Copy link
Copy Markdown
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem.

@zwoop zwoop merged commit 1f07ce3 into apache:master Nov 1, 2017
@zwoop zwoop modified the milestones: 8.0.0, 7.1.2 Nov 1, 2017
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Nov 1, 2017

Cherry-picked to 7.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion when setting proxy.config.ssl.max_record_size=-1

3 participants