Add zombie-event option to debug leaked Http2ClientSessions.#3713
Merged
shinrich merged 1 commit intoapache:masterfrom May 25, 2018
Merged
Add zombie-event option to debug leaked Http2ClientSessions.#3713shinrich merged 1 commit intoapache:masterfrom
shinrich merged 1 commit intoapache:masterfrom
Conversation
This was referenced May 22, 2018
a-canary
reviewed
May 24, 2018
| case VC_EVENT_INACTIVITY_TIMEOUT: | ||
| case VC_EVENT_ERROR: | ||
| case VC_EVENT_EOS: | ||
| this->set_dying_event(event); |
Collaborator
There was a problem hiding this comment.
set_dying_event() is not called anywhere else in code. Should it be?
Member
Author
There was a problem hiding this comment.
No, all the dying eventually comes through this handler.
shinrich
force-pushed
the
h2-zombie-debug
branch
2 times, most recently
from
a3aae5b to
c423ac2
Compare
| Http2StreamDebug(cstate.ua_session, id, "Received DATA frame"); | ||
|
|
||
| if (cstate.get_zombie_event()) { | ||
| Warning("Data frame for zombied sessoin %" PRId64, cstate.ua_session->connection_id()); |
| Http2StreamDebug(cstate.ua_session, stream_id, "Received PING frame"); | ||
|
|
||
| if (cstate.get_zombie_event()) { | ||
| Warning("Ping frame for zombied sessoin %" PRId64, cstate.ua_session->connection_id()); |
Member
There was a problem hiding this comment.
I thought you had said you were going to handle PING differently and reset the zombie timeout in that case.
| if (edata == fini_event) { | ||
| if (edata == zombie_event) { | ||
| // zombie session is still around. Assert | ||
| ink_release_assert(zombie_event == nullptr); |
Member
There was a problem hiding this comment.
You might want something more like ink_release_assert(!"Zombie HTTP/2 event occurred");
SolidWallOfCode
approved these changes
May 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging option. If you enable the feature, it will schedule zombie events when one but not both of the Session shutdown requirements is set. If the zombie event goes off (presumably long after the session should have finished cleaning up), the traffic server process will assert.
This has been incredibly useful in debugging some Http2ClientSession clean scenarios (more PR's to come).