Set verify locations in the initializer function only#3834
Merged
persiaAziz-zz merged 1 commit intoapache:masterfrom Jun 14, 2018
Merged
Set verify locations in the initializer function only#3834persiaAziz-zz merged 1 commit intoapache:masterfrom
persiaAziz-zz merged 1 commit intoapache:masterfrom
Conversation
zwoop
changed the title
Member
|
This is a performance tweak, so the overhead of setting / loading the verify locations is per certificate and not per connection. |
shinrich
approved these changes
Jun 14, 2018
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
Looks good. The trusted root locations are not overridable so only need to be loaded on initialization. Only the default locations or the specific locations should be loaded for a given CTX.
Contributor
|
Cherry-picked to 8.0.x |
Contributor
|
@persiaAziz If you want this for 7.1.x, please make a PR against that branch (this doesn't cherry-pick cleanly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.