REVERTED: Do not do DNS if there is a matching parent and object is HIT-STALE #3987
Merged
vmamidi merged 1 commit intoapache:masterfrom Jul 19, 2018
Merged
REVERTED: Do not do DNS if there is a matching parent and object is HIT-STALE #3987vmamidi merged 1 commit intoapache:masterfrom
vmamidi merged 1 commit intoapache:masterfrom
Conversation
Member
|
What happens if there is no parent selection? Does the child not get the address for the upstream? |
Contributor
Author
|
Child will get upstream address if there are no parents or go_direct is true and all the parents are down. |
Member
|
I wonder why that code was put there in the first place. It does look like |
SolidWallOfCode
approved these changes
Jul 19, 2018
Contributor
Author
|
I cleaned up most of the code while working on fixing the HostDB deadlocks #1756 . |
Contributor
|
I've reverted this, we observed a crasher, outlined in #4009. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2376