Skip to content

REVERTED: Do not do DNS if there is a matching parent and object is HIT-STALE #3987

Merged
vmamidi merged 1 commit intoapache:masterfrom
vmamidi:no_dns_hit_stale
Jul 19, 2018
Merged

REVERTED: Do not do DNS if there is a matching parent and object is HIT-STALE #3987
vmamidi merged 1 commit intoapache:masterfrom
vmamidi:no_dns_hit_stale

Conversation

@vmamidi
Copy link
Copy Markdown
Contributor

@vmamidi vmamidi commented Jul 19, 2018

This fixes #2376

@vmamidi vmamidi added this to the 7.1.5 milestone Jul 19, 2018
@vmamidi vmamidi self-assigned this Jul 19, 2018
@zwoop zwoop modified the milestones: 7.1.5, 9.0.0 Jul 19, 2018
@SolidWallOfCode
Copy link
Copy Markdown
Member

What happens if there is no parent selection? Does the child not get the address for the upstream?

@vmamidi
Copy link
Copy Markdown
Contributor Author

vmamidi commented Jul 19, 2018

Child will get upstream address if there are no parents or go_direct is true and all the parents are down.
HandleCacheOpenReadHit handles all the possible scenarios.

@SolidWallOfCode
Copy link
Copy Markdown
Member

I wonder why that code was put there in the first place. It does look like HandleCacheOpenReadHit will do address resolution if the address for the server isn't valid. I also wonder why it checks force_dns rather than checking the server.dst_addr directly.

@vmamidi
Copy link
Copy Markdown
Contributor Author

vmamidi commented Jul 19, 2018

I cleaned up most of the code while working on fixing the HostDB deadlocks #1756 .

@vmamidi vmamidi merged commit a8ec551 into apache:master Jul 19, 2018
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Jul 25, 2018

I've reverted this, we observed a crasher, outlined in #4009.

@zwoop zwoop removed this from the 9.0.0 milestone Aug 9, 2018
@zwoop zwoop changed the title Do not do DNS if there is a matching parent and object is HIT-STALE REVERTED: Do not do DNS if there is a matching parent and object is HIT-STALE Aug 9, 2018
@zwoop zwoop added Revert and removed Revert labels Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child makes DNS request for stale objects

3 participants