Disables the double test for inconsistent execution#4133
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Sep 9, 2018
Merged
Disables the double test for inconsistent execution#4133SolidWallOfCode merged 1 commit intoapache:masterfrom
SolidWallOfCode merged 1 commit intoapache:masterfrom
Conversation
This test appears to be brittle, but it is being used to gate acceptance of pull request. Therefore it should be disabled by default until the inconsistency can be sorted out.
dragon512
approved these changes
Aug 28, 2018
Contributor
dragon512
left a comment
dragon512
left a comment
There was a problem hiding this comment.
This test and the test like it have a race on stats being updated correctly in a certain timeframe. I agree that this should be disabled until we create a better way to know that the stats are up-to-date rather than adding long delays and hoping everything is synced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test appears to be brittle, but it is being used to gate acceptance of pull request. Therefore it should be disabled by default until the inconsistency can be sorted out.
Found in #4131, but I have seen this before in a local environment and in other Pull Requests.
Relates to #4113
A permanent fix for this work-around is tracked by #4120 .