Skip to content

sometimes ua_session comes back empty #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmorilha wants to merge 1 commit into from
Closed

sometimes ua_session comes back empty #4158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions proxy/http2/Http2ConnectionState.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,8 +1183,9 @@ Http2ConnectionState::release_stream(Http2Stream *stream)
// We were shutting down, go ahead and terminate the session
// this is a member of Http2ConnectionState and will be freed
// when ua_session is destroyed
ua_session->destroy();

if (ua_session) {
Copy link
Copy Markdown
Contributor

@masaori335 masaori335 Aug 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird because ua_session is already null-checked in above (line # 1169).

ua_session->destroy();
Copy link
Copy Markdown
Contributor

@bryancall bryancall Aug 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not seeing this issue in our 7.1.x or in 8.0.x. Makes sense to not destroy if ua_session is nullptr.

}
// Can't do this because we just destroyed right here ^,
// or we can use a local variable to do it.
// ua_session = nullptr;
Expand Down