TextView: Better support for std::string assignment.#4175
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Sep 10, 2018
Merged
TextView: Better support for std::string assignment.#4175SolidWallOfCode merged 1 commit intoapache:masterfrom
SolidWallOfCode merged 1 commit intoapache:masterfrom
Conversation
shinrich
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For inexplicable reasons,
std::string_viewdoesn't have good support for assignment fromstd::stringand we can'tusingthe methods down because there are subtle differences that need to be preserved.This is split out of #4168.