TextView: Add support for use as "Source" in STL containers.#4176
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Sep 11, 2018
Merged
TextView: Add support for use as "Source" in STL containers.#4176SolidWallOfCode merged 1 commit intoapache:masterfrom
SolidWallOfCode merged 1 commit intoapache:masterfrom
Conversation
dragon512
previously approved these changes
Sep 11, 2018
Contributor
|
@SolidWallOfCode There are conflicts |
SolidWallOfCode
force-pushed
the
textview-source
branch
from
c27f0ea to
105b34e
Compare
dragon512
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up while working with
std::filesystem.TextViewwas always designed to act like an iterator, this provides STL support for that. In particular the change to the dereference operators makesTextViewlook like a C-string to various STL interfaces (e.g.std::filesystem::path) without requiring an actual null terminating byte.This is split from #4168.