TS-4133: Update the url_sig plugin so that application query paramete…#424
Closed
jrushford wants to merge 1 commit intoapache:masterfrom
Closed
TS-4133: Update the url_sig plugin so that application query paramete…#424jrushford wants to merge 1 commit intoapache:masterfrom
jrushford wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@jrushf1239k Please address the concerns and update the pull request. |
jrushford
force-pushed
the
ts4133
branch
2 times, most recently
from
ebe3742 to
d14dfbd
Compare
Contributor
Author
|
Updated the README and added source code comments on the requirement that signing query parameters must always be appended to the end of any application query parameters in the request. Added a check that limits the length of query parameters to no more than MAX_QUERY_LEN or 4096 bytes. This length should be sufficient. |
jrushford
force-pushed
the
ts4133
branch
2 times, most recently
from
f1cca2b to
2949f43
Compare
…rs are left intact on the request.
Contributor
Author
|
changes were pushed to master, closing this pull request. |
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Apr 13, 2017
Ftywan
pushed a commit
to Ftywan/trafficserver
that referenced
this pull request
Dec 21, 2022
Add arm64 to the list of known stack growth directions. (cherry picked from commit 697da39) Co-authored-by: Mo Chen <uncorrupt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TS-4133. This update to url_sig will allow application query parameters destined for an origin server to remain intact rather than stripping all query parameters after request signing validation.