BWF: Fix handling of null char * - avoid string_view constructor.#4718
Merged
shinrich merged 1 commit intoapache:masterfrom Dec 18, 2018
Merged
BWF: Fix handling of null char * - avoid string_view constructor.#4718shinrich merged 1 commit intoapache:masterfrom
shinrich merged 1 commit intoapache:masterfrom
Conversation
shinrich
previously approved these changes
Dec 18, 2018
SolidWallOfCode
force-pushed
the
bwf-nullptr-fix
branch
from
d2a27e3 to
b5cbe07
Compare
shinrich
previously approved these changes
Dec 18, 2018
SolidWallOfCode
force-pushed
the
bwf-nullptr-fix
branch
from
b5cbe07 to
197cdd8
Compare
shinrich
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only seems to be a problem on FreeBSD/clang, but reasonable to fix anyway.