TS-4220 DNSHandler::mainEvent#493
Closed
scw00 wants to merge 1 commit intoapache:masterfrom
scw00:patch-2
Closed
Conversation
Dear all failover_now return false when the name server's mark is not expiring, and we need to call rr_failure to mark the name server as down. Thx!!
Closed
Contributor
|
Same pull request as #492 |
Member
Author
|
sry！！ |
Member
|
I commented on the bug report but I'll repeat here - having looked at the code, I think the original is correct and this is not correct. failover_now() is true if it is time to fail the nameserver which is consistent with the current code. |
Contributor
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Jul 23, 2021
9.1.x 2021 07 01
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all
failover_now return false when the name server's mark is not expiring, and we need to call rr_failure to mark the name server as down.
Thx!!