Ran clang-tidy#5182
Merged
masaori335 merged 3 commits intoapache:masterfrom Mar 20, 2019
Merged
Conversation
masaori335
force-pushed
the
ran-clang-tidy
branch
2 times, most recently
from
a838b11 to
d3ed2d6
Compare
"proxy/logging/LogField.h" is changed by hand to follow changes made by performance-unnecessary-value-param to "proxy/logging/LogAccess.h".
masaori335
force-pushed
the
ran-clang-tidy
branch
from
d3ed2d6 to
8153594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran clang-tidy with current settings.
Below changes made by hand.
NOLINT(modernize-deprecated-headers)to below files which are included by both of C and C++ file.Change proxy/logging/LogField.h to follow changes made by
performance-unnecessary-value-paramto proxy/logging/LogAccess.hExclude whole
lib/yamlcpp-> Do not run clang-tidy on lib/yamlcpp/ #5183Add
NOLINTNEXTLINE(modernize-use-nullptr)forink_thread