Separate out common header compression logic to hdrs directory#5465
Merged
maskit merged 1 commit intoapache:masterfrom Jul 10, 2019
Merged
Separate out common header compression logic to hdrs directory#5465maskit merged 1 commit intoapache:masterfrom
maskit merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
This is for H2 and H3, but I want an approval from somebody not working on QUIC because this change comes from QUIC branch. |
02cbb71 to
aeb375b
Compare
Member
Author
|
[approve ci autest] |
bryancall
approved these changes
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of preparation to merge quit-latest branch. Because some of header compression logic are common between HPACK and QPACK, I separated out the logic to hdrs directory.
The code come from quic-latest branch, and it has been working for long time on a QUIC test sever (both H2 and H3 are enabled).
Only change I made is adding
nparameter toencode_stringanddecode_string. On HPACKnis always7but QPACK passes other values.Current:
New: