Skip to content

Grab lock before invoke#5508

Merged
duke8253 merged 1 commit intoapache:masterfrom
duke8253:master-hook_invoke
May 15, 2019
Merged

Grab lock before invoke#5508
duke8253 merged 1 commit intoapache:masterfrom
duke8253:master-hook_invoke

Conversation

@duke8253
Copy link
Copy Markdown
Contributor

This is causing occasional crashes during startup, similar to #4919.

@duke8253 duke8253 added the Crash label May 15, 2019
@duke8253 duke8253 added this to the 9.0.0 milestone May 15, 2019
@duke8253 duke8253 requested a review from SolidWallOfCode May 15, 2019 15:25
@duke8253 duke8253 self-assigned this May 15, 2019
Copy link
Copy Markdown
Contributor

@vmamidi vmamidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the need for this. I am curious to know which plugin is crashing and why is it crashing?

@duke8253
Copy link
Copy Markdown
Contributor Author

duke8253 commented May 15, 2019

@vmamidi I know for sure #5454 was failing because of this, this crashes because we modified the invoke method to check for locks and left the call to it untouched.

@duke8253 duke8253 merged commit 6f01d77 into apache:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants