HTTP/2: increment write_vio.ndone by consumed size#5633
Merged
masaori335 merged 1 commit intoapache:masterfrom Jun 17, 2019
Merged
HTTP/2: increment write_vio.ndone by consumed size#5633masaori335 merged 1 commit intoapache:masterfrom
masaori335 merged 1 commit intoapache:masterfrom
Conversation
maskit
approved these changes
Jun 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @SolidWallOfCode pointed out on slack, when Http2Stream handle response header,
write_vio.ndoneshould be incremented by the size whichHTTPHdr::parse_resp()used.When the
stateisPARSE_RESULT_DONE,this->response_header.length_get()is same tobytes_used, but when thestateisPARSE_RESULT_CONT, they are different. In that case, this could be problem.