Add slow logs for HTTP/2 Connection & Stream#5747
Merged
masaori335 merged 1 commit intoapache:masterfrom Aug 1, 2019
Merged
Conversation
Contributor
|
We should follow the same design as slow log, naming the configuration option similar and having it a threshold vs on or off Alternatively this could be done with the normal logging. |
952aca8 to
3f4f384
Compare
Contributor
Author
|
To follow HTTP/1.1 slow log design, add configs for threshold.
|
vmamidi
approved these changes
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to HTTP Slow Log, record and print HTTP/2 milestones to figure out bottleneck.
Prefix of logs are
[CONNECTION ID][CONNECTION ID] [STREAM ID] [HTTP SM ID]The first field (
open) is absolute timestamp to compare with other logs. Other fields are relative time from theopenfield.Example of milestones
We might want to add more milestones. Let's do it on separate PR.