Cleanup: Remove unused function & old comments#5825
Merged
masaori335 merged 1 commit intoapache:masterfrom Aug 15, 2019
Merged
Conversation
masaori335
commented
Aug 14, 2019
| // determination that HTTP/2 will be used by both peers, each endpoint MUST | ||
| // send a connection preface as a final confirmation ... | ||
| // this->write_buffer->write(HTTP2_CONNECTION_PREFACE, | ||
| // HTTP2_CONNECTION_PREFACE_LEN); |
Contributor
Author
There was a problem hiding this comment.
It looks like this comment comes from old draft of HTTP/2.
RFC7540 says below about connection preface from server side.
The server connection preface consists of a potentially empty
SETTINGS frame (Section 6.5) that MUST be the first frame the server
sends in the HTTP/2 connection.
Member
|
[approve ci autest] |
maskit
approved these changes
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.