Allow disabling HTTP/2 priority frames limit#5888
Conversation
sudheerv
left a comment
There was a problem hiding this comment.
For consistency and completeness, I think we should've similar disable mechanism for rate limiting the Settings, Ping, Error Rate as well.
|
[approve ci autest] |
|
@jvgutierrez Would you mind making similar changes for the other rate limiting settings ? If not, I'm ok landing this, and make a separate PR. |
|
Also, it feels that if proxy.config.http2.stream_priority_enabled == 0, we ought to ignore the frames rather than rate limiting them ? |
e9d7b1e to
be88436
Compare
PR updated, now the limit is only enforced if |
be88436 to
c798c39
Compare
shinrich
left a comment
There was a problem hiding this comment.
Looks good to me. Unfortunately, the PR needs to be rebased due to other merges causing conflicts.
c798c39 to
cd4582c
Compare
done! |
|
Cherry-picked to v9.0.x branch. |
As discussed yesterday on Slack, there are some scenarios, specially when
proxy.config.http2.stream_priority_enabledis set to0where disabling HTTP/2 priority frames limit is interesting. This PR allows to disable it by settingproxy.config.http2.max_priority_frames_per_minuteto0