Refactor Http1Session to derive from ProxySession#5898
Refactor Http1Session to derive from ProxySession#5898a-canary wants to merge 1 commit intoapache:masterfrom
Conversation
61a40cd to
633dec1
Compare
|
Ready for review @shinrich @masaori335 @maskit @ZhangZizhong |
|
I think the clang-format should be done by a separate PR because it would make backporting complicated. |
|
clang-format was done by #5902. Please remove the commit. |
| { | ||
| // TODO: refactor this | ||
| ink_assert(0); | ||
| } |
There was a problem hiding this comment.
Is this a functional intermediate step? I assume the original versions of these methods are still around and are being used instead of the new stubs?
There was a problem hiding this comment.
These stubs are the undefined virtual functions of ProxySession. Some existing functions matched the name but not the signature.
Yes, this an intermediate step. Note the "// TODO: refactor this"
A step towards H2-to-Origin. This contains minimal change to compile, and a few TODO comments. This will be followed by many PRs to refactor and cleanup methods and variables. + fix overrides +
633dec1 to
4da68e6
Compare
|
removing format and rebasing |
maskit
left a comment
There was a problem hiding this comment.
This contains minimal change to compile, and a few TODO comments. This will be followed by many PRs to refactor and cleanup methods and variables.
I'm ok with this change, but I'm a bit worried about how long this journey takes.
- Does / Should the refactoring block 9.0 release?
- Can we release 9.0 in the middle of refactoring? (Will master be in good shape on each step?)
At the moment I have 4 commits queued up for separate PRs. Because like you said, I want the CI to verify each commit to keep the master branch stable. |
This is up to RM, but basically backports to 9.0.x are only open for bug fixes once 9.0.0 has been released, 9.1 can have other changes though. I don't think passing tests is enough. Intermediate state can unnecessarily increase complexity. At the moment, Why don't we have a feature branch for this refactoring? |
|
Ok. i'm going to close this PR and open merge this into a feature branch called h1outbound. |
A step towards H2-to-Origin.
This contains minimal change to compile, and a few TODO comments. This will be followed by many PRs to refactor and cleanup methods and variables.