[TS-4383] Allow group and others to read from the log pipe.#595
Closed
calavera wants to merge 2 commits intoapache:masterfrom
Closed
[TS-4383] Allow group and others to read from the log pipe.#595calavera wants to merge 2 commits intoapache:masterfrom
calavera wants to merge 2 commits intoapache:masterfrom
Conversation
ASCII_PIPE logs are created with 0600 privileges. The owner of this pipe is `nobody` and the group is `nogroup`. This is very limiting and it makes impossible to use the pipe to read logs. Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
changed the title
Contributor
|
Group definitely seems reasonable. Let's not do other yet? |
Contributor
Author
|
@jpeach nobody will be able to access it with only group either, because the group is |
Contributor
|
Do you build Traffic Server with |
Signed-off-by: David Calavera <david.calavera@gmail.com>
Contributor
Author
|
mmm, for some reason I thought it was the default, but yes, that's what we're using. If it's not the default, I agree that giving only access to the group is more reasonable. I made the change. |
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
Cherry pick event loop changes
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
…)" (apache#595) This reverts commit f0a7f6d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASCII_PIPE logs are created with 0600 privileges.
The owner of this pipe is
nobodyand the group isnogroup.This is very limiting and it makes impossible to use the pipe to read
logs.
Signed-off-by: David Calavera david.calavera@gmail.com