Add a config for internal HPACK header table size limit#6055
Merged
maskit merged 1 commit intoapache:masterfrom Oct 24, 2019
Merged
Add a config for internal HPACK header table size limit#6055maskit merged 1 commit intoapache:masterfrom
maskit merged 1 commit intoapache:masterfrom
Conversation
This introduces proxy.config.http2.header_table_size_limit that enables to configure internal HPACK header table size limit currently hard coded as 64KB.
Member
Author
|
@zwoop @bryancall This is the config we talked at the last summit. Actually we already had a mechanism to limit table size ATS uses, which was introduced on #1711, but the size is hard coded. This PR makes the limit configurable. |
shinrich
approved these changes
Oct 23, 2019
masaori335
approved these changes
Oct 24, 2019
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
It's useful making the limit configurable.
Contributor
|
This is going into 8.1.0, so therefore, we should also put it into 9.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces proxy.config.http2.header_table_size_limit that enables to configure internal HPACK header table size limit currently hard coded as 64KB.
The default value is the same as the hard coded value.