Fail on missing body factory#6232
Closed
shinrich wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
Author
|
[approve ci centos] |
bneradt
approved these changes
Dec 5, 2019
| Warning("Unable to access() directory '%s': %d, %s", (const char *)directory_of_template_sets, errno, strerror(errno)); | ||
| Warning(" Please set 'proxy.config.body_factory.template_sets_dir' "); | ||
| Fatal("Unable to access() directory '%s': %d, %s. Please set 'proxy.config.body_factory.template_sets_dir' ", | ||
| (const char *)directory_of_template_sets, errno, strerror(errno)); |
Contributor
There was a problem hiding this comment.
I think .get() can work here instead of the cast:
directory_of_template_sets.get(), errno, ...
Member
Author
|
Closing this in deference to PR #6203. In our hack-a-thon meeting today, the consensus was that this was the preferred approach to the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative fix to issue #5102. My preferred fix is in PR #6203. But if we do want to keep the template_sets_dir relative to the configuration directory rather than the install directory, this PR will fail if the body_factory cannot be loaded and the PR updates the documentation for the setting to reflect the new relative base path.