Fix rare H2 Start/Close Hook misses#6344
Closed
a-canary wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Delay transactions on lock failure Fixes to preserver VCONN_CLOSE and SSN_CLOSE orderings Fix threading issues verification code. Inflated number of request to test with higher thread contention.
Member
|
[approve ci autest] |
1 similar comment
Member
|
[approve ci autest] |
Contributor
|
The |
Member
|
Yes, failed two of 3 times (random java failure the other time). Will dig in. |
This was referenced Jan 28, 2020
Collaborator
Author
|
replaced with #6364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing rare failures on autest/openclose_h2, which lead to a number of fixes mostly performed by @shinrich
Changes include:
Delay transactions on lock failures, so the open hook happens before the close hook, and before the destroy.
Fixes to preserver VCONN_CLOSE and SSN_CLOSE orderings
Fix threading issues verification code.
Inflated number of requests to test with higher thread contention.