Fix heap-use-after-free on Http2Stream::destroy()#6346
Merged
masaori335 merged 1 commit intoapache:masterfrom Jan 27, 2020
Merged
Fix heap-use-after-free on Http2Stream::destroy()#6346masaori335 merged 1 commit intoapache:masterfrom
masaori335 merged 1 commit intoapache:masterfrom
Conversation
masaori335
commented
Jan 24, 2020
masaori335
force-pushed
the
6345
branch
2 times, most recently
from
4e6df85 to
feecbae
Compare
masaori335
changed the title
maskit
reviewed
Jan 27, 2020
| h2_proxy_ssn->connection_state.release_stream(this); | ||
|
|
||
| cid = _proxy_ssn->connection_id(); | ||
| // Do not access `_proxy_ssn` in below. It might be freed by `release_stream`. |
Member
There was a problem hiding this comment.
Looks familiar. Don't we have a similar comment somewhere? Or did we remove it and now putting it back? We may want something we can avoid the heap-use-after-free.
Contributor
Author
There was a problem hiding this comment.
This one? I agree with we need something.
trafficserver/proxy/http2/Http2ConnectionState.cc
Lines 1378 to 1382 in 48bcbe6
maskit
approved these changes
Jan 27, 2020
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
I'm not sure if this fix the issue, but the change makes sense.
shinrich
approved these changes
Jan 27, 2020
Contributor
|
Cherry-picked to v9.0.x branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6345.