Add virtual destructors for Http2TxFrame, Http2FrequencyCounter#6348
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Jan 27, 2020
Merged
Conversation
randall
approved these changes
Jan 27, 2020
Contributor
|
Obviously, this is the way. |
Contributor
|
Assuming optimal vague linkage, there will only be one copy of the virtual table for each dynamic class in memory. An additional virtual function only adds a pointer and a this pointer offset to the virtual table. So a small price to cover the case when the virtual destructor is actually needed (instance of a derived class is created in the heap and deleted using a pointer to its base class). https://stackoverflow.com/a/461224 |
Contributor
|
I believe this depends on 48bcbe6 |
zwoop
added
the
OnDocs
Contributor
|
Cherry-picked to v9.0.x branch. |
zwoop
removed
the
OnDocs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent potential future issues by following the rule of any class that needs virtual methods must have a virtual destructor.