Adjust consume logic in data frame read#6450
Merged
shinrich merged 1 commit intoapache:masterfrom Feb 28, 2020
Merged
Conversation
Contributor
We can get rid of the while loop. If |
shinrich
force-pushed
the
fix-data-frame-consume
branch
from
3f61cc2 to
b626ab3
Compare
Member
Author
|
Updated the commit to remove the while loop and add error as @masaori335 suggested. |
Contributor
|
Cherry-picked to v9.0.x branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic error from the HTTP/2 post rework. If you got through this loop multiple times, you will over-consume the receive buffer. I assume we generally do not go through this loop multiple times.