TS-4487: fix write_to_net_io issues#673
Conversation
| } | ||
| } | ||
|
|
||
| if (needs==0 && !buf.reader()->read_avail()) { |
There was a problem hiding this comment.
Should use read_avail_more_than(0) here for performance as the exact number of bytes is irrelevant.
|
I think the right thing to do is push PR #629. That moves the read/write loops to use the IOBuffer interface instead of the IOBlock interface. I've been holding off on this one until the event loop changes landed since it solved a real problem I had seen. But if other folks are seeing problems in this area the IOBuffer interface code is much easier to reason about and debug. |
|
vote on PR #629, but the 2nd issue: did not check the change of lock after return from wbe callback, not included. |
|
Good point on the lock check. Could have finished the current vio in the signal and then end of mysteriously disabling the next vio. |
|
Due to the #629 already merged, I will update the patch to fit it. |
This addresses a couple clang-13 issues in our internal Edge Traffic Server branch. One is a missing declaration of startEvent, the other a duplicated function definition. Both of these are mistakes I introduced from our opensource 9.2.x merge a few months ago.
4 participants
No description provided.