Skip to content

clang-analyzer: uninitialized va_list #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
May 20, 2020
Merged

clang-analyzer: uninitialized va_list #6798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/tscore/Diags.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,15 +460,12 @@ Diags::dump(FILE *fp) const
void
Diags::error_va(DiagsLevel level, const SourceLocation *loc, const char *format_string, va_list ap) const
{
va_list ap2;

if (DiagsLevel_IsTerminal(level)) {
va_copy(ap2, ap);
}

print_va(nullptr, level, loc, format_string, ap);

if (DiagsLevel_IsTerminal(level)) {
va_list ap2;

va_copy(ap2, ap);
if (cleanup_func) {
cleanup_func();
}
Expand All @@ -479,9 +476,8 @@ Diags::error_va(DiagsLevel level, const SourceLocation *loc, const char *format_
} else {
ink_fatal_va(format_string, ap2);
}
va_end(ap2);
}

va_end(ap2);
}

/*
Expand Down