TS-4496: Remove ink_code_md5_stringify#686
Conversation
| bool recordRestartCheck(const char *varName); | ||
|
|
||
| void fileCheckSum(char *buffer, int size, char *checksum, const size_t checksumSize); | ||
| void fileCheckSum(char *buffer, int size, char *checksum); |
There was a problem hiding this comment.
I could not find any call of fileCheckSum. Should we remove this too?
|
Yeah, I think it's fine to cleanup unused code from mgmt/Web*. We've made many efforts of nuking the Web portions of all this, so likely these are remnants that got unused. |
|
Seems reasonable to me. I checked the history and both of these seem to have been put in at the same time, although I can't imagine why both were needed. |
| @@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id) | |||
| tsapi TSMgmtError | |||
| TSEncryptPassword(char *passwd, char **e_passwd) | |||
There was a problem hiding this comment.
Probably better to just remove TSEncryptPassword altogether?
There was a problem hiding this comment.
I agree with that. Do we need API review to remove? This looks like one of TS API.
There was a problem hiding this comment.
No we don't need to do API review for the management API, only for plugin APIs.
On Jun 2, 2016, at 9:37 AM, Masaori Koshiba notifications@github.com wrote:
In mgmt/api/INKMgmtAPI.cc:
@@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id)
tsapi TSMgmtError
TSEncryptPassword(char _passwd, char *_e_passwd)
I agree with that. Do we need API review to remove? This looks like one of TS API.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
There was a problem hiding this comment.
OK, I'll just remove this.
|
Passed builds and test on the CI. https://ci.trafficserver.apache.org/view/github/job/Github-Linux/49/ |
- Remove ink_code_md5_stringify - Remove unused functions (fileCheckSum and TSEncryptPassword)
|
Looks good, ship it. |
|
[approve ci] |
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/104/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/81/ for details. |
|
FreeBSD build successful https://ci.trafficserver.apache.org/job/Github-FreeBSD/189/ |
(cherry picked from commit 7da3e1c)
… private and also explicitly add code to avoid any copies. (apache#8888) (apache#686) (cherry picked from commit 2f05312)
5 participants
TS-4496