Skip to content

Cleanup: Write error message on diags output instead of stderr #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masaori335 merged 1 commit into from
Jul 14, 2020
Merged

Cleanup: Write error message on diags output instead of stderr #6997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions proxy/http/HttpTunnel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,9 +1499,7 @@ HttpTunnel::finish_all_internal(HttpTunnelProducer *p, bool chain)
ink_assert(c->write_vio->nbytes >= 0);

if (c->write_vio->nbytes < 0) {
// TODO: Wtf, printf?
fprintf(stderr, "[HttpTunnel::finish_all_internal] ERROR: Incorrect total_bytes - c->skip_bytes = %" PRId64 "\n",
static_cast<int64_t>(total_bytes - c->skip_bytes));
Copy link
Copy Markdown
Contributor Author

@masaori335 masaori335 Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of total_bytes & c->skip_bytes are int64_t

Error("Incorrect total_bytes - c->skip_bytes = %" PRId64 "\n", total_bytes - c->skip_bytes);
}
}

Expand Down