Skip to content

Avoid unnecessary copying of STL map for QUICTPConfigQCP class. #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywkaras merged 1 commit into from
Jul 28, 2020
Merged

Avoid unnecessary copying of STL map for QUICTPConfigQCP class. #7039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iocore/net/QUICNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class QUICTPConfigQCP : public QUICTPConfig
}
}

std::unordered_map<uint16_t, std::pair<const uint8_t *, uint16_t>>
const std::unordered_map<uint16_t, std::pair<const uint8_t *, uint16_t>> &
additional_tp() const override
{
return this->_additional_tp;
Expand Down
30 changes: 15 additions & 15 deletions iocore/net/quic/QUICTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,21 +520,21 @@ class QUICPathValidationData
class QUICTPConfig
{
public:
virtual ~QUICTPConfig() = default; // required
virtual uint32_t no_activity_timeout() const = 0;
virtual const IpEndpoint *preferred_address_ipv4() const = 0;
virtual const IpEndpoint *preferred_address_ipv6() const = 0;
virtual uint32_t initial_max_data() const = 0;
virtual uint32_t initial_max_stream_data_bidi_local() const = 0;
virtual uint32_t initial_max_stream_data_bidi_remote() const = 0;
virtual uint32_t initial_max_stream_data_uni() const = 0;
virtual uint64_t initial_max_streams_bidi() const = 0;
virtual uint64_t initial_max_streams_uni() const = 0;
virtual uint8_t ack_delay_exponent() const = 0;
virtual uint8_t max_ack_delay() const = 0;
virtual uint8_t active_cid_limit() const = 0;
virtual bool disable_active_migration() const = 0;
virtual std::unordered_map<uint16_t, std::pair<const uint8_t *, uint16_t>> additional_tp() const = 0;
virtual ~QUICTPConfig() = default; // required
virtual uint32_t no_activity_timeout() const = 0;
virtual const IpEndpoint *preferred_address_ipv4() const = 0;
virtual const IpEndpoint *preferred_address_ipv6() const = 0;
virtual uint32_t initial_max_data() const = 0;
virtual uint32_t initial_max_stream_data_bidi_local() const = 0;
virtual uint32_t initial_max_stream_data_bidi_remote() const = 0;
virtual uint32_t initial_max_stream_data_uni() const = 0;
virtual uint64_t initial_max_streams_bidi() const = 0;
virtual uint64_t initial_max_streams_uni() const = 0;
virtual uint8_t ack_delay_exponent() const = 0;
virtual uint8_t max_ack_delay() const = 0;
virtual uint8_t active_cid_limit() const = 0;
virtual bool disable_active_migration() const = 0;
virtual const std::unordered_map<uint16_t, std::pair<const uint8_t *, uint16_t>> &additional_tp() const = 0;
};

class QUICLDConfig
Expand Down