Don't send image/webp responses from cache to broswers that don't support it#7104
Merged
bryancall merged 5 commits intoapache:masterfrom Aug 14, 2020
Merged
Don't send image/webp responses from cache to broswers that don't support it#7104bryancall merged 5 commits intoapache:masterfrom
bryancall merged 5 commits intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #7099
What this patch does is only use exact match with the client Accept header field and
Content-Type: image/webpif there is a webp response in cache.This change is also dependent on
proxy.config.http.cache.ignore_accept_mismatchset to 0. Alternatively I can make the change independent ofproxy.config.http.cache.ignore_accept_mismatch. Feedback is welcomed.