Skip to content

Cleanup: remove unnecessary memset() within dns_process() #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oknet merged 1 commit into from
Sep 22, 2020
Merged

Cleanup: remove unnecessary memset() within dns_process() #7209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions iocore/dns/DNS.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,21 +1590,17 @@ dns_process(DNSHandler *handler, HostEnt *buf, int len)
// Once it's full, a new entry get inputted into try_server_names round-
// robin style every 50 success dns response.

// TODO: Why do we do strlen(e->qname) ? That should be available in
// e->qname_len, no ?
if (local_num_entries >= DEFAULT_NUM_TRY_SERVER) {
if ((attempt_num_entries % 50) == 0) {
try_servers = (try_servers + 1) % countof(try_server_names);
ink_strlcpy(try_server_names[try_servers], e->qname, MAXDNAME);
memset(&try_server_names[try_servers][strlen(e->qname)], 0, 1);
attempt_num_entries = 0;
}
++attempt_num_entries;
} else {
// fill up try_server_names for try_primary_named
try_servers = local_num_entries++;
ink_strlcpy(try_server_names[try_servers], e->qname, MAXDNAME);
memset(&try_server_names[try_servers][strlen(e->qname)], 0, 1);
}

/* added for SRV support [ebalsa]
Expand Down