option to disable compression for range request's response

doc/admin-guide/plugins/compress.en.rst

@@ -103,6 +103,12 @@ versions of the content as :term:`alternates <alternate>`. When set to
 ``false``, |TS| will cache only the compressed or decompressed variant returned
 by the origin. Enabled by default.
 
+range-request
+-----
+
+When set to ``true``, causes |TS| to compress responses to Range Requests.
+Disabled by default. Setting this to true while setting cache to false leads to delivering corrupted content.
+
 compressible-content-type
 -------------------------
 

plugins/compress/compress.cc

@@ -629,7 +629,7 @@ transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configuration
   /* Client request header */
   TSMBuffer cbuf;
   TSMLoc chdr;
-  TSMLoc cfield;
+  TSMLoc cfield, rfield;
 
   const char *value;
   int len;
@@ -661,13 +661,25 @@ transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configuration
     return 0;
   }
 
+  // check if Range Requests are cacheable
+  bool range_request = host_configuration->range_request();
+  rfield             = TSMimeHdrFieldFind(cbuf, chdr, TS_MIME_FIELD_RANGE, TS_MIME_LEN_RANGE);
+  if (rfield != TS_NULL_MLOC && !range_request) {
+    debug("Range header found in the request and range_request is configured as false, not compressible");
+    TSHandleMLocRelease(cbuf, chdr, rfield);
+    TSHandleMLocRelease(cbuf, TS_NULL_MLOC, chdr);
+    TSHandleMLocRelease(bufp, TS_NULL_MLOC, hdr_loc);
+    return 0;
+  }
+
   // the only compressible method is currently GET.
   int method_length;
   const char *method = TSHttpHdrMethodGet(cbuf, chdr, &method_length);
 
   if (!(method_length == TS_HTTP_LEN_GET && memcmp(method, TS_HTTP_METHOD_GET, TS_HTTP_LEN_GET) == 0)) {
     debug("method is not GET, not compressible");
     TSHandleMLocRelease(cbuf, TS_NULL_MLOC, chdr);
+    TSHandleMLocRelease(bufp, TS_NULL_MLOC, hdr_loc);
     return 0;
   }
 

plugins/compress/configuration.cc

@@ -105,6 +105,7 @@ enum ParserState {
   kParseRemoveAcceptEncoding,
   kParseEnable,
   kParseCache,
+  kParseRangeRequest,
   kParseFlush,
   kParseAllow,
   kParseMinimumContentLength
@@ -347,6 +348,8 @@ Configuration::Parse(const char *path)
           state = kParseEnable;
         } else if (token == "cache") {
           state = kParseCache;
+        } else if (token == "range-request") {
+          state = kParseRangeRequest;
         } else if (token == "flush") {
           state = kParseFlush;
         } else if (token == "supported-algorithms") {
@@ -379,6 +382,10 @@ Configuration::Parse(const char *path)
         current_host_configuration->set_cache(token == "true");
         state = kParseStart;
         break;
+      case kParseRangeRequest:
+        current_host_configuration->set_range_request(token == "true");
+        state = kParseStart;
+        break;
       case kParseFlush:
         current_host_configuration->set_flush(token == "true");
         state = kParseStart;

plugins/compress/configuration.h

@@ -48,6 +48,7 @@ class HostConfiguration : private atscppapi::noncopyable
     : host_(host),
       enabled_(true),
       cache_(true),
+      range_request_(false),
       remove_accept_encoding_(false),
       flush_(false),
       compression_algorithms_(ALGORITHM_GZIP),
@@ -66,6 +67,16 @@ class HostConfiguration : private atscppapi::noncopyable
     enabled_ = x;
   }
   bool
+  range_request()
+  {
+    return range_request_;
+  }
+  void
+  set_range_request(bool x)
+  {
+    range_request_ = x;
+  }
+  bool
   cache()
   {
     return cache_;
@@ -131,6 +142,7 @@ class HostConfiguration : private atscppapi::noncopyable
   std::string host_;
   bool enabled_;
   bool cache_;
+  bool range_request_;
   bool remove_accept_encoding_;
   bool flush_;
   int compression_algorithms_;