Skip to content

s3_auth: demote noisy errors around configuration that doesn't affect plugin usability #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randall merged 1 commit into from
Nov 2, 2020
Merged

s3_auth: demote noisy errors around configuration that doesn't affect plugin usability #7306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/s3_auth/s3_auth.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,16 @@ class S3Config
/* Optional parameters, issue warning if v2 parameters are used with v4 and vice-versa (wrong parameters are ignored anyways) */
if (2 == _version) {
if (_v4includeHeaders_modified && !_v4includeHeaders.empty()) {
TSError("[%s] headers are not being signed with AWS auth v2, included headers parameter ignored", PLUGIN_NAME);
TSDebug("[%s] headers are not being signed with AWS auth v2, included headers parameter ignored", PLUGIN_NAME);
}
if (_v4excludeHeaders_modified && !_v4excludeHeaders.empty()) {
TSError("[%s] headers are not being signed with AWS auth v2, excluded headers parameter ignored", PLUGIN_NAME);
TSDebug("[%s] headers are not being signed with AWS auth v2, excluded headers parameter ignored", PLUGIN_NAME);
}
if (_region_map_modified && !_region_map.empty()) {
TSError("[%s] region map is not used with AWS auth v2, parameter ignored", PLUGIN_NAME);
TSDebug("[%s] region map is not used with AWS auth v2, parameter ignored", PLUGIN_NAME);
}
if (nullptr != _token || _token_len > 0) {
TSError("[%s] session token support with AWS auth v2 is not implemented, parameter ignored", PLUGIN_NAME);
TSDebug("[%s] session token support with AWS auth v2 is not implemented, parameter ignored", PLUGIN_NAME);
}
} else {
/* 4 == _version */
Expand Down