Skip to content

Eliminate dangling pointer into stack space. #7392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywkaras merged 1 commit into from
Dec 21, 2020
Merged

Eliminate dangling pointer into stack space. #7392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/tscore/ink_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,10 @@ struct InkAtomicList {
#define INK_ATOMICLIST_EMPTY(_x) (!((FREELIST_POINTER((_x.head)))))
#endif

// WARNING: the "name" string is not copied, it has to be a statically-stored constant string.
//
inkcoreapi void ink_atomiclist_init(InkAtomicList *l, const char *name, uint32_t offset_to_next);

inkcoreapi void *ink_atomiclist_push(InkAtomicList *l, void *item);
void *ink_atomiclist_pop(InkAtomicList *l);
inkcoreapi void *ink_atomiclist_popall(InkAtomicList *l);
Expand Down
6 changes: 2 additions & 4 deletions proxy/logging/Log.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,11 +1116,9 @@ Log::create_threads()
flush_notify = new EventNotify;
flush_data_list = new InkAtomicList;

sprintf(desc, "Logging flush buffer list");
ink_atomiclist_init(flush_data_list, desc, 0);
ink_atomiclist_init(flush_data_list, "Logging flush buffer list", 0);
Continuation *flush_cont = new LoggingFlushContinuation(0);
sprintf(desc, "[LOG_FLUSH]");
eventProcessor.spawn_thread(flush_cont, desc, stacksize);
eventProcessor.spawn_thread(flush_cont, "[LOG_FLUSH]", stacksize);
}

/*-------------------------------------------------------------------------
Expand Down